-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import to fix local build failure #277
base: main
Are you sure you want to change the base?
Conversation
Huh, this is so weird. I can't reproduce locally.
|
I can reproduce it going back to the commit that added it. I don't have any working theory why. |
Just for reference, I have the same versions on this branch, and on main I get
I was getting |
Do you have some global sbt plugins configured? That's the only other thing I can imagine would be affecting your environment. |
I do, I have |
I've isolated it to a global sbt-updates. |
yeah, he does 😆 |
And here's why. The two implicits have the same name. |
I think it still makes sense to move forward with adding the import, right? It's not going to cause a problem to have it, and it'll prevent stumbling for folks who do have a global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A better solution would be to get the upstream plugins to rename theirs, but I don't think this hurts anything in the interim, and it helps at least two of us.
Without this import, loading the build locally would fail with the following:
I'm not sure why it hasn't been failing in CI though?