Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Core - H2Server - Split for comprehension #6613

Merged
merged 7 commits into from
Aug 18, 2022

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Aug 15, 2022

Redo of #6525 in a series of commits, to make each change obvious, to attend @armanbilge
comment in #6523 (comment)

Each commit is easier to review, specially if hiding whitespace changes.


In the ember-core package, in the H2Server, the fromSocket method,
we refactor the code to split the main expression, a for comprehension
in Resource, to extract a couple of methods in F:

  • Initialising the H2Connection itself.
  • Clear closed streams from the map of streams.
  • Process a created stream, which includes handling push promises.

This is similar to recent PR #6523, and follows on previous PRs like #6425.

Note: Half of line changes are whitespace-only.

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:ember-core labels Aug 15, 2022
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great. Very easy to follow :) thanks for refactoring.

@armanbilge armanbilge added this to the v0.23.15 milestone Aug 17, 2022
@armanbilge armanbilge added the behind-the-scenes Appreciated, but not user-facing label Aug 17, 2022
@armanbilge armanbilge merged commit 77e4f3a into http4s:series/0.23 Aug 18, 2022
@diesalbla diesalbla deleted the embercore-split-h2server-bis branch August 19, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
behind-the-scenes Appreciated, but not user-facing module:ember-core series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants