Ember Core - H2Server - Split for comprehension #6613
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #6525 in a series of commits, to make each change obvious, to attend @armanbilge
comment in #6523 (comment)
Each commit is easier to review, specially if hiding whitespace changes.
In the
ember-core
package, in the H2Server, thefromSocket
method,we refactor the code to split the main expression, a for comprehension
in
Resource
, to extract a couple of methods inF
:This is similar to recent PR #6523, and follows on previous PRs like #6425.
Note: Half of line changes are whitespace-only.