-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add svm-subs #167
Add svm-subs #167
Conversation
src/main/g8/build.sbt
Outdated
"ch.qos.logback" % "logback-classic" % LogbackVersion | ||
"ch.qos.logback" % "logback-classic" % LogbackVersion, | ||
$if(graal_native_image.truthy)$ | ||
"org.scalameta" %% "svm-subs" % "20.2.0" % "compile-internal" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this needs to align with the GraalVM version. Is there any way to introspect it?
I don't see any evidence adding this jar worked? |
I had a very good experience with sbt-native-image, the README is excellent. In particular, it automatically takes care of the svn-subs dependency. |
I found that and it does look simpler. I just didn't quickly find its story on static binaries, which was important to the original contributor. /cc @Drocsid |
@rossabaker I removed Honestly, I don't fully understand all the mechanics behind these changes, but it looks better now. I wonder, should we give a try to |
I have little experience in this, but people are speaking well of native image. This stops the bleeding, so I think we should merge this now and keep improving. |
Based on this idea. I'm still not clear what made all the native builds suddenly bitrot, and I don't know how the sbt-native-image plugin interferes with the static instructions we have. I don't have any idea what I'm doing.