Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svm-subs #167

Merged
merged 2 commits into from
Nov 1, 2020
Merged

Add svm-subs #167

merged 2 commits into from
Nov 1, 2020

Conversation

rossabaker
Copy link
Member

Based on this idea. I'm still not clear what made all the native builds suddenly bitrot, and I don't know how the sbt-native-image plugin interferes with the static instructions we have. I don't have any idea what I'm doing.

"ch.qos.logback" % "logback-classic" % LogbackVersion
"ch.qos.logback" % "logback-classic" % LogbackVersion,
$if(graal_native_image.truthy)$
"org.scalameta" %% "svm-subs" % "20.2.0" % "compile-internal"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this needs to align with the GraalVM version. Is there any way to introspect it?

@rossabaker
Copy link
Member Author

I don't see any evidence adding this jar worked?

@amesgen
Copy link
Member

amesgen commented Oct 18, 2020

I had a very good experience with sbt-native-image, the README is excellent. In particular, it automatically takes care of the svn-subs dependency.

@rossabaker
Copy link
Member Author

I found that and it does look simpler. I just didn't quickly find its story on static binaries, which was important to the original contributor.

/cc @Drocsid

@satorg
Copy link
Contributor

satorg commented Oct 31, 2020

@rossabaker I removed % "compile-internal" from svm-subs and seems it fixes the Actions.

Honestly, I don't fully understand all the mechanics behind these changes, but it looks better now.

I wonder, should we give a try to sbt-native-image or keep moving with just svm-subs?

@rossabaker
Copy link
Member Author

I have little experience in this, but people are speaking well of native image. This stops the bleeding, so I think we should merge this now and keep improving.

@rossabaker rossabaker merged commit 228297f into 0.21 Nov 1, 2020
@satorg satorg deleted the svm-subs branch November 3, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants