-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource-based simple constructors #1015
Open
ybasket
wants to merge
7
commits into
http4s:series/0.9
Choose a base branch
from
ybasket:feature/#1011-client-as-resource
base: series/0.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Resource-based simple constructors #1015
ybasket
wants to merge
7
commits into
http4s:series/0.9
from
ybasket:feature/#1011-client-as-resource
Commits on Feb 3, 2024
-
Add Resource-based simple constructors
As Java 21+ allows explicitly closing clients, this adds new constructors that return the clients wrapped in a Resource. On older Java versions, the release is a no-op, on newer it enforces the cleanup of resources. Also ensures the websocket client closes the input channel on release so the connection gets properly closed. Closes http4s#1011
Configuration menu - View commit details
-
Copy full SHA for 33ca4c9 - Browse repository at this point
Copy the full SHA 33ca4c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0384cb9 - Browse repository at this point
Copy the full SHA 0384cb9View commit details
Commits on Nov 7, 2024
-
Merge pull request http4s#1121 from http4s/update/series/0.9/http4s-c…
…ore-0.23.29 Update http4s-client, ... to 0.23.29 in series/0.9
Configuration menu - View commit details
-
Copy full SHA for 2b71c70 - Browse repository at this point
Copy the full SHA 2b71c70View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f098c - Browse repository at this point
Copy the full SHA c5f098cView commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0f8e981 - Browse repository at this point
Copy the full SHA 0f8e981View commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4cd2f14 - Browse repository at this point
Copy the full SHA 4cd2f14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d2262d - Browse repository at this point
Copy the full SHA 3d2262dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.