issue #953: stop using writeHead

object.keys in web-incoming.js results in a non-deterministic ordering of keys, which means that in web-outgoing writeHead might be called before setHeader, which throws an error
http-party · Apr 20, 2018 · 2c44039 · 2c44039
1 parent 8097ae2
commit 2c44039
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/http-proxy/passes/web-outgoing.js b/lib/http-proxy/passes/web-outgoing.js
@@ -137,9 +137,10 @@ module.exports = { // <--
   writeStatusCode: function writeStatusCode(req, res, proxyRes) {
     // From Node.js docs: response.writeHead(statusCode[, statusMessage][, headers])
     if(proxyRes.statusMessage) {
-      res.writeHead(proxyRes.statusCode, proxyRes.statusMessage);
+      res.statusCode = proxyRes.statusCode;
+      res.statusMessage = proxyRes.statusMessage;
     } else {
-      res.writeHead(proxyRes.statusCode);
+      res.statusCode = proxyRes.statusCode;
     }
   }