Fixed mobile header clickable area to be full width #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamingrobot
changed the title
|
@gamingrobot thanks for your PR |
cyberflamingo
pushed a commit
to cyberflamingo/hyde-hyde
that referenced
this pull request
Jul 30, 2019
Fixed mobile header clickable area to be full width
nankeen
pushed a commit
to nankeen/hyde-hyde
that referenced
this pull request
Apr 22, 2020
Fixed mobile header clickable area to be full width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile the header clickable area is not the full width of header so you can see the padding on the sides when it is tapped.
This resolves that by removing the padding on the sidebar container and offsetting the background image, the visual results are identical but now the clickable area is the full header.