configure script improvements regarding pkg-config support #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Explorer09
commented
Aug 20, 2024
Explorer09
commented
- Move the macro call of PKG_PROG_PKG_CONFIG.
- Bring back the warning when configure is generated without pkg.m4
- CI FreeBSD job now installs pkg-config.
|
Minor note: Solaris 11.4 in our CI build jobs supports pkg-config, but the system doesn't seem to come with pkg.m4. So the warning would always exist if you generate htop's configure script there. |
Explorer09
force-pushed
the
pkg-config-init
branch
from
3c3f21c
to
0af14d0
Compare
BenBE
added
the
build system 🔧
|
I added a change in the README to mention the use of |
BenBE
approved these changes
Aug 23, 2024
Explorer09
force-pushed
the
pkg-config-init
branch
2 times, most recently
from
5f0980d
to
16e9bdc
Compare
Explorer09
force-pushed
the
pkg-config-init
branch
from
16e9bdc
to
1ef344e
Compare
pkg-config will be used for detecting 'curses' library in a future
commit. We have been using pkg-config for detecting multiple libraries
('hwloc' and formerly 'libnl'), thus the PKG_PROG_PKG_CONFIG macro
should be called early.
Signed-off-by: Kang-Che Sung <[email protected]>
Commit 24b1513 removed the warning when the configure script is generated without pkg.m4. I added that warning years ago (see 103f1a4) to prevent downstream distributions from creating a tarball with an "incomplete" configure script. Add the warning back, reword the messages to tell exactly what feature would be missing (to builders), and also add FORCE_MAKE_DIST variable for builders who want to ignore the warning. :) Signed-off-by: Kang-Che Sung <[email protected]>
This allows configure to be generated with pkg.m4 in FreeBSD build job.
Explorer09
force-pushed
the
pkg-config-init
branch
from
1ef344e
to
6a1ebd4
Compare
Code style fix.
|
Merged as part of #1512 … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.