Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework ZramMeter and remove MeterClass.comprisedValues #1286

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Rework ZramMeter and remove MeterClass.comprisedValues #1286

merged 3 commits into from
Aug 29, 2023

Commits on Aug 26, 2023

  1. Explicitly ignore NaN values in BarMeterMode_draw() 

    Do not throw FP exceptions if any value in a Meter object is a NaN.

Signed-off-by: Kang-Che Sung <[email protected]>
    @Explorer09
    Explorer09 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    348cc26 View commit details
    Browse the repository at this point in the history

  2. Rework ZramMeter and remove MeterClass.comprisedValues 

    The 'comprisedValues' boolean property unnecessarily complicates the
drawing algorithms of Bar meters and Graph meters. Since the only user
of 'comprisedValues' is ZramMeter, it is better to rework the meter so
that it no longer needs 'comprisedValues'.

The 'values[ZRAM_METER_UNCOMPRESSED]' now stores the difference between
uncompressed and compressed data size.

Signed-off-by: Kang-Che Sung <[email protected]>
    @Explorer09
    Explorer09 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    04a6943 View commit details
    Browse the repository at this point in the history

  3. Fix Meter.c #include order; no code changes

    @Explorer09
    Explorer09 committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    d542916 View commit details
    Browse the repository at this point in the history