Deprecate the sanitizer and recommend Bleach #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
+ Coverage 90.97% 91.07% +0.09%
==========================================
Files 49 50 +1
Lines 6936 7044 +108
Branches 1322 1341 +19
==========================================
+ Hits 6310 6415 +105
- Misses 468 475 +7
+ Partials 158 154 -4
Continue to review full report at Codecov.
|
jgraham
reviewed
Jun 12, 2020
| @@ -11,6 +12,13 @@ | |||
| __all__ = ["Filter"] | |||
|
|
|||
|
|
|||
| warnings.warn( | |||
| "html5lib's sanitizer is deprecated; see " + | |||
There was a problem hiding this comment.
Seems like this string could be a global.
g-k
approved these changes
Jun 15, 2020
| * Try to import from `collections.abc` to remove DeprecationWarning and ensure | ||
| `html5lib` keeps working in future Python versions. (#403) | ||
| * Drop optional `datrie` dependency. (#442) | ||
| * Try to import from ``collections.abc`` to remove DeprecationWarning and ensure |
|
Should probably also make sure the docs reflect this. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #443. cc/ @jgraham @g-k