Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #124: Move to webencodings for decoding the input byte stream. #137

Merged
merged 1 commit into from
Jan 12, 2016

Conversation

gsnedders
Copy link
Member

Fixes #124. Note this currently fails a large number of tests because of html5lib/html5lib-tests#37. As the changelog notes, this adds a dependency on @SimonSapin's webencodings.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/521

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@SimonSapin
Copy link
Contributor

Note that the e.name attribute of webencodingd.Encoding objects is the name in http://encoding.spec.whatwg.org/.

Not all such names are recognized in Python. e.codec_info.name is, except for the x-user-defined encoding that does not exist in Python and webencoding defines. To fix that, use eg. e.codec_info.streamreader instead of codecs.getreader(). (Not that x-user-defined is very useful anyway…)

@SimonSapin
Copy link
Contributor

Still, documentEncoding (#123) should be the spec name, or even the Encoding object.

@gsnedders
Copy link
Member Author

Note without html5lib/html5lib-tests#40 this fails a fair number of tests.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.54% when pulling 2abaeae on gsnedders:webencodings into 46dae3d on html5lib:master.

@gsnedders
Copy link
Member Author

Build seems to be passing with XPASSes, hmm.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.54% when pulling d659cf3 on gsnedders:webencodings into 46dae3d on html5lib:master.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.54% when pulling ff8bbf8 on gsnedders:webencodings into 46dae3d on html5lib:master.

@gsnedders
Copy link
Member Author

@jgraham r?

gsnedders added a commit that referenced this pull request Jan 12, 2016
Fix #124: Move to webencodings for decoding the input byte stream.
@gsnedders gsnedders merged commit 93ee3b3 into html5lib:master Jan 12, 2016
@gsnedders gsnedders deleted the webencodings branch May 7, 2016 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoding Standard
4 participants