-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #124: Move to webencodings for decoding the input byte stream. #137
Conversation
Critic review: https://critic.hoppipolla.co.uk/r/521 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Note that the Not all such names are recognized in Python. |
Still, |
Note without html5lib/html5lib-tests#40 this fails a fair number of tests. |
|
Build seems to be passing with XPASSes, hmm. |
|
|
@jgraham r? |
e171691
to
85723e2
Compare
Fix #124: Move to webencodings for decoding the input byte stream.
Fixes #124. Note this currently fails a large number of tests because of html5lib/html5lib-tests#37. As the changelog notes, this adds a dependency on @SimonSapin's webencodings.