Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tokens to being objects #24

Open
gsnedders opened this issue Apr 16, 2013 · 2 comments
Open

Move tokens to being objects #24

gsnedders opened this issue Apr 16, 2013 · 2 comments
Labels
enhancement
Milestone
2.0

Comments

@gsnedders
Copy link
Member

Using hashtables for tokens makes no sense; we should move to objects and then have the type implicit.
@gsnedders
Copy link
Member Author

Also note we have two different types of tokens: the tokenizer ones and the treewalker ones, which are not the same (because of attributes and namespaces).

@gsnedders gsnedders mentioned this issue Jun 26, 2013
Closed
gsnedders added a commit to gsnedders/html5lib-python that referenced this issue Nov 24, 2014
@gsnedders
Merge pull request html5lib#24 from nolanw/select-parse-errors
7faff61 
Add parse errors for some <template> tests.
@gsnedders gsnedders mentioned this issue Feb 26, 2020
Open
@jayaddison jayaddison mentioned this issue Dec 16, 2020
Closed
@jayaddison jayaddison mentioned this issue Dec 29, 2020
Closed
@jayaddison
Copy link
Contributor

@gsnedders I've been doing a little work towards this (partly out of curiosity to see what the impact could be like), and should soon have a branch ready to offer with tokens-as-objects and a few related cleanups (attribute handling, in particular).

So far I'm seeing slight performance degradation as a result, so I'm doing a bit of investigation to figure out what might be causing that.

@jayaddison jayaddison mentioned this issue Dec 30, 2020
Closed
@ambv ambv modified the milestones: 2.0, 1.1 Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Tokenizer: use Python objects to represent tokens
3 participants
@ambv @gsnedders @jayaddison