-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
as it's the common location and easier to find for new developers.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,7 +111,7 @@ def findRequirements(platform): | |
Read the requirements.txt file and parse into requirements for setup's | ||
install_requirements option. | ||
""" | ||
requirementsPath = fixPath(os.path.join(PY_BINDINGS, "requirements.txt")) | ||
requirementsPath = fixPath(os.path.join(REPO_DIR, "requirements.txt")) | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
breznak
Author
Member
|
||
return [ | ||
line.strip() | ||
for line in open(requirementsPath).readlines() | ||
|
1 comment
on commit 46514b2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an other option for setup.py to package the requirements file (it does know where it is located)
As I understand it, the requirement is that setup.py and requirements.txt files (and l bunch of other things) be in the top directory of the wheel package. Setup.py knows to look for them in the same folder. The wheel is constructed from the contents of build\Release\distr
. I used a folder inside the build folder so it does not modify our git source tree.
So we have options for how to construct this folder. Right now I copy bindings\py\packaging
into that folder and then add the contents of py/src
and the extension libraries. I do this both in setup.py and in CMake. We probably don't need it in CMake but at the time I thought there was a reason.
What this means is that the requirements.txt file will not be included in the PYPI package.
That would cause pip install to fail (assuming we someday get that to work).