-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is
and as
support for std::expected
(v2)
#971
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have accidentally moved the built-in as
code section.
@bluetarpmedia i will take a look after a decision on how to implement is and as functions. #701 (comment) |
Forward declare the `as` function templates for `std::expected` since they're not found by ADL
Thanks, restored now! |
Sorry for the lag one this. I think this in in pri-5, at least in part because I'm not sure if this PR has fallen behind the other is/as cleanup that was merged this summer (my fault, sorry). Do you want to refresh this PR and it might move to pri-3? |
cpp2util.h
to supportis
andas
forstd::expected
pure2-expected-is-as
regression testThis replaces the original PR #954; I couldn't successfully rebase it onto the updated changes in
main
so I gave up and created a new PR!CC @filipsajdak
EDIT - The
macOS
build job is a spurious failure (not found for compiler: 'clang++'
). I'm not sure why this happens but I've seen it a few times now. I don't have permission to retry the job in this repo, but in my own fork I just retry the job and it succeeds.EDIT 2 - See PR #972 for the spurious macOS job failure