Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(to_cpp1): define type-scope object alias with wildcard type inline #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(to_cpp1): define type-scope object alias with wildcard type inline #706

wants to merge 1 commit into from

Conversation

JohelEGP
Copy link
Contributor

@JohelEGP JohelEGP commented Sep 26, 2023 •
edited
Loading

Resolves #700.
Resolves #842.
Resolves #1221.

@JohelEGP JohelEGP mentioned this pull request Sep 29, 2023
Open
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from a3eebc6 to c147335 Compare October 3, 2023 19:42
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from 4e5fa7f to 88d0fa2 Compare October 31, 2023 16:11
@JohelEGP JohelEGP changed the title fix(cpp1): define static data member in the class body if possible fix(cpp1): define static data member with placeholder type in class Oct 31, 2023
@JohelEGP JohelEGP changed the title fix(cpp1): define static data member with placeholder type in class fix(to_cpp1): define static data member with placeholder type in class Nov 9, 2023
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from f9f06d3 to 2892889 Compare November 9, 2023 21:32
@JohelEGP

This comment was marked as resolved.

Sign in to view
@JohelEGP

This comment was marked as resolved.

Sign in to view
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from 884d180 to 8c1505d Compare December 11, 2023 16:22
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from 8c1505d to 0ff280a Compare December 23, 2023 15:35
@JohelEGP JohelEGP changed the title fix(to_cpp1): define static data member with placeholder type in class fix(to_cpp1): define type-scope object alias with wildcard type inline Dec 23, 2023
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from 0ff280a to 9226b2a Compare October 1, 2024 16:31
@JohelEGP JohelEGP mentioned this pull request Oct 4, 2024
Open
@JohelEGP JohelEGP force-pushed the potentially_incomplete_type branch from 5069915 to 928f1fb Compare October 9, 2024 16:29
@hsutter
Copy link
Owner

hsutter commented Oct 31, 2024

Hi! Sorry it took me so long to get to this one... but this looks like it might still be current despite the age.

Is this up to date, and would you like me to review it?

@hsutter hsutter added the question - further information requested Further information is requested label Oct 31, 2024
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Oct 31, 2024 •
edited
Loading

Yes, and yes, please do.
There's still the question of whether this is the right solution to the problem.

A somewhat related problem is the inability to have static objects (at type or namespace scope)
that are constexpr of a type defined in the current TU
due to its constructors being lowered in the last phase
but the static object themselves being lowered in the previous phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
question - further information requested Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@JohelEGP @hsutter