test: update to test what is intented and clarify with comments #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
referenced
this pull request
Aug 13, 2023
JohelEGP
referenced
this pull request
Aug 13, 2023
…unnamed parameters, closes #560 Emit `[[maybe_unused]]` on a `that` parameter if the class is empty. Add -Wunused-parameter to my GCC and Clang regression tests. Add `_` unnamed parameter support, and use ordinals instead of line/col numbers to keep the generated names stable. As an example from one of the updated regression tests that had a helper function to just accept (but not use) five generic parameters, that function is now just: `call: (_, _, _, _, _) = { }`
JohelEGP
commented
Aug 14, 2023
| main: (args) = { | ||
| x: quantity = (1729); | ||
| _ = x + x; // Not `(void) x + x`; would attempt to add a `void` to `x`. | ||
| _ = args; // Not `void(args)`; would attempt to declare `args` with `void` type. |
There was a problem hiding this comment.
This scary syntax can be used to smuggle declarations:
https://cpp2.godbolt.org/z/EsGKsThz3
main: () = i32(x);
auto main() -> int { cpp2::i32(x); }main.cpp2:1:32: warning: unused variable 'x' [-Wunused-variable]
1 | auto main() -> int { cpp2::i32(x); }
| ^
1 warning generated.
Program returned: 0
There was a problem hiding this comment.
Delightful! FWIW Wparentheses would flag that.
|
Thanks! I did notice that the test was losing some of its intent, I appreciate this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out at db63152#r124283230 and 6ce2643#r124372924,
those recent commits did or could change what the test was meant to test.
This PR realigns the test cases with their original intent,
and clarifies with comments the possible implementations it avoids.