FIX: Remove next() on backtrack, fixes #404 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to parse expression like:
```cpp
(:() = 0) as t;
```
`parameter_declaration_list()` fail to succed which is expected but
skips one symbol ('(') on returning that makes parser fail to process
expression succesfully.
|
Ah, thanks! Right, if we backtrack we shouldn't then do another |
zaucy
pushed a commit
to zaucy/cppfront
that referenced
this pull request
Dec 5, 2023
When trying to parse expression like:
```cpp
(:() = 0) as t;
```
`parameter_declaration_list()` fail to succed which is expected but
skips one symbol ('(') on returning that makes parser fail to process
expression succesfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to parse expressions like:
(:() = 0) as t;parameter_declaration_list()fail to succeed, which is expected but skips one symbol ('(') on returning, which makes the parser fail to process the expression successfully.After this change above expression is parsed correctly. All regression tests pass.
Fixes #404