-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial clang-tidy configuration #1253
Conversation
Thanks for your pull request! It looks like this may be your first contribution to cppfront. I've emailed you the Contributor License Agreement (CLA), and once it's signed I can look at your pull request. Thanks again for your contribution. |
Signed. |
Got it, thanks Radu! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Here are some comments, and I've already gone and applied them myself.
Looks good, we just have the reflect.h merge conflict... usually the line numbers changes don't cause a conflict, and maybe the simplest workaround is to move the reflect.h/h2 changes to a separate PR? |
I hid the initialization thing for now cause some didn't like the immediately invoked lambda expression..., without that the line number changes are no longer an issue I think I'll leave it until you relax the rules for out parameters. |
# Conflicts: # source/reflect.h
how can I get those workflows approved? |
I'm sure Herb is busy with CppCon right now. The conference opens tomorrow and he has the opening keynote on Monday morning. |
Signed-off-by: Herb Sutter <[email protected]>
Signed-off-by: Herb Sutter <[email protected]>
Thanks! |
This adds some configuration to clang tidy, more to come in the future as well as more fixes to the code to go along with it.
Thanks.