Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unparsed markdown from copyright footer #74

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Dec 4, 2023

Fixes #61. This doesn't aim to resolve the underlying copyright question pointed out in #61 (@klieret, what's "not accurate" about it?), but it fixes the parsing issue.

@wdconinc wdconinc linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link

welcome bot commented Dec 4, 2023

Thanks for opening your first pull request here 🚀! If you have any questions, feel free to mention one of the conveners, previous contributors, or attend our weekly meeting (see
our homepage). Also, sometimes PRs go unnoticed, so don't hesitate to @mention some of us, if we do not come back to you within a few days.

@klieret
Copy link
Member

klieret commented Dec 6, 2023

Ah, regarding the "not accurate", I don't see anything that is based off of the carpentries (neither content nor framework), but I guess it says "originally". Anyway, doesn't matter :)

@klieret
Copy link
Member

klieret commented Dec 6, 2023

I'll leave this for @jonas-eschle to merge :)

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 6, 2023

As far as I can tell, the content of the git lesson is based on git-novice originally, making this a derived work. Someone went through and turned it from md to rst for rtd before swcarpentry did the same on their end :-)

@klieret
Copy link
Member

klieret commented Dec 6, 2023

Ah, you're right, I had only checked the python lesson! Makes a lot of sense then :)

@wdconinc
Copy link
Contributor Author

wdconinc commented Dec 6, 2023

Same with shell. (And apparently it's still md and the analysis essentials framework runs pandoc on it.)

@jonas-eschle jonas-eschle merged commit 7820455 into master Jan 9, 2024
2 checks passed
@jonas-eschle jonas-eschle deleted the 61-broken-copyright-footer branch January 9, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken copyright footer
3 participants