Revert "chore: remap path prefix for reproducible builds" #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrzlgnm
force-pushed
the
revert-451-chore/reproducible-builds
branch
from
1b30784
to
325f952
Compare
This reverts commit a40439b.
hrzlgnm
force-pushed
the
revert-451-chore/reproducible-builds
branch
from
325f952
to
2370598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #451
I had a look at the produced binaries and those still did contain paths from the build system, so the changes was useless or incomplete and needs more investigation. Or perhaps we should wait when trim-paths from RFC-3127is available in rust / cargo.