Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel remote disc streaming connects faster #9478

Merged
merged 4 commits into from
Mar 22, 2017

Conversation

unknownbrackets
Copy link
Collaborator

Previously, if you hit cancel, you could wait many seconds for your cancel to register, and the UI would appear to hang.

Now, it checks the flag while connecting, so it cancels much quicker - less than a second always.

This also puts Back in a fixed position at the bottom of the dev tools screen, streaming connect screen, and streaming settings screen. I left it on the right side in the streaming browse area.

-[Unknown]

@hrydgard hrydgard merged commit c35461b into hrydgard:master Mar 22, 2017
@hrydgard
Copy link
Owner

Nice!

By the way I found a related issue a while ago, that I then forgot about - if you leave HTTP URLs in the Recent list that are no longer available (say the server is down), PPSSPP can hang a long time trying to show the Recents screen...

@unknownbrackets unknownbrackets deleted the remoteiso branch March 22, 2017 14:04
@unknownbrackets
Copy link
Collaborator Author

That shouldn't happen, at least not anymore. The problem was on startup, we did a (synchronous) Exists check on every item in the Recent list. It should probably do it, and just be async.

Anyway, the workaround I added in #8845 was to always pass http URLs, so they would fail only once clicked or once the game info in 429346b.

-[Unknown]

@hrydgard
Copy link
Owner

Okay, I'll see if I can repro later.

@hrydgard
Copy link
Owner

Oh yeah, there was another Exists() call coming from GameInfoCache that hung, should probably work to replace it with ExistsFast...

@unknownbrackets
Copy link
Collaborator Author

Hmm, I just tested it with a bad IP and an IP not listening on port 80, and it was fine? Was something listening on the port, but not actually serving HTTP?

-[Unknown]

@hrydgard
Copy link
Owner

I think what I did was that I had a PPSSPP game server running on one machine on my local network, played from that on the other machine, then I shut down the server (the entire machine or just PPSSPP, don't remember) and started the emulator again on the other machine. As it tried to load the icon to display, it hung. But maybe I committed a workaround that I don't remember :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants