IMPL Some Mpeg and Handle ringbufferAddr =0 in sceMpegCreate #867
Conversation
ref #508 please help to check whether I IMPL correctly
|
|
||
| u32 sceMpegAvcResourceFinish(u32 mpeg) | ||
| { | ||
| return 0; |
There was a problem hiding this comment.
Don't forget to add a log above here.
-[Unknown]
There was a problem hiding this comment.
Add this ?
INFO_LOG(HLE,"sceMpegAvcResourceFinish(%08x)", mpeg);
There was a problem hiding this comment.
Sure, or even just DEBUG, just so we know it's getting called when we're trying to see what's going on.
-[Unknown]
|
Well, they need to be properly implemented probably, but not many games call them. If this makes that game get farther, then I think it's good enough for now until we figure them out more. Aside from some inconsistent tabs it looks okay. -[Unknown] |
|
Still need 1 more fix to make that game run further (mpeg bug).Do I need merge this first ? |
|
What's the other fix? Well, if this is helping I think it's not bad to merge it. But if it still doesn't seem improved in any way and we don't have any tests, might be better to try to figure out what's wrong still first... -[Unknown] |
|
I haved tested ringbufferAddr =0 in sceMpegCreate make game crash. |
|
Ah, interesting. I guess the resource functions mean it doesn't use a ringbuffer? Cool, so it gets farther now with those changes? -[Unknown] |
|
Then full of UNIMPL _sceAtracGetContextAddress<0> |
| @@ -77,6 +77,7 @@ | |||
| static const int NUM_ES_BUFFERS = 2; | |||
|
|
|||
| static const int PSP_ERROR_MPEG_NO_DATA = 0x80618001; | |||
| static const int PSP_ERROR_MPEG_INVALID_VALUE = 0x806101fe; | |||
There was a problem hiding this comment.
Are those two const ints really needed? Identical values are defined in enum in sceMpeg.h.
There was a problem hiding this comment.
Thanks.I have removed
|
@hrydgard I am ready merge when you don't find any probrem. |
|
Alright for now, but your return value for sceMpegAvcResourceGetAvcDecTopAddr could have some bad effects if unlucky... |
IMPL Some Mpeg and Handle ringbufferAddr =0 in sceMpegCreate
|
@hrydgard |
ref #508
please help to check whether I IMPL correctly