Handle branches in VFPU delay slots better #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on tests on a PSP, all branches are attempted. The behavior is technically undefined. It seems to take the delay slot's target if they differ and both pass. This is the behavior the interpreter has, but it's more work in jit. Since only a couple games seem to do this, and clearly expect this behavior, this fixes all known cases of hrydgard#1926.
hrydgard
added a commit
that referenced
this pull request
Aug 15, 2013
Handle branches in VFPU delay slots better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interpreter seems to already have the correct behavior and match the PSP. From my tests, although I'm not 100% confident for all cases it's true, the logic is as follows:
That is, if 4 in a row pass and each has a different target, take target 2. If only 2 and 3 pass, take 3. If only 1 and 3 pass, take 1.
However, we've only seen 3 games do this, and they're all by the same developer, I'm assuming the important thing is to handle their case: multiple tests with the same target. This is relatively easy.
Fixes #1926.
-[Unknown]