Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better control profile for Retroid devices, minor fixes and cleanup #19550

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Oct 23, 2024

Also fixes two theming problems from #18802 and two broken translations

@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Oct 23, 2024
@hrydgard hrydgard added this to the v1.18.0 milestone Oct 23, 2024
@hrydgard hrydgard added the Translation Translation-related issues label Oct 23, 2024
@hrydgard hrydgard merged commit 05ef4ed into master Oct 23, 2024
19 checks passed
@hrydgard hrydgard deleted the yes-more-fixes branch October 23, 2024 15:55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the hardcoded value was the same as the Default ItemDownStyleBg. However, here ItemFocusedStyle gets applied instead. This leads to the highlighted Back button blending into the top bar.

image
image

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, right. Not ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. Translation Translation-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants