Replacement: Do all I/O on threaded tasks #17091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens to the recently build |
|
I have no idea, can't be related to this issue, i wouldn't think ... |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce I/O stutter during texture replacement considerably (especially on slow I/O like on Android 11+), no more I/O is done on the main thread by the replacer anymore except at startup.
We still open each file twice, I'll try to merge the Populate/Prepare steps later to avoid it.Never mind, went ahead and merged them, now we only open each file once. We still first detect size, then pad the size if needed, rewind and read again.I believe decimation of the "level cache" can still race against texture loading in some interesting ways. Need to look into that later.