Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeList: fix SDL+Wayland+Vulkan #16251

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

gucio321
Copy link
Contributor

fix #16163

NOTE Please verify carefully this change since I'm not familiar with CMake at all and I could destroy something 😄

@unknownbrackets
Copy link
Collaborator

I think this is better, but there was #11536 for some reason. Maybe a case of https://xkcd.com/1172/.

-[Unknown]

@gucio321
Copy link
Contributor Author

ok, so how should I handle this?

@gucio321
Copy link
Contributor Author

well, what is the default state of USE_WAYLAND_WSI? is it OFF or just ""?
if so, I can check if it was OFF and if so, skip Wayland detection

@gucio321
Copy link
Contributor Author

ok, nevermind, I see that cmake doesn't do this way ;-)

@hrydgard
Copy link
Owner

Hm. Not sure what to do here :)

I feel that ideally we should always build with both X11 and wayland and chose at runtime...

@hrydgard
Copy link
Owner

Again I'm really not sure why #11536 was desired, but I also don't really see why this PR could be bad. So I'm inclined to merge it...

@TheComputerGuy96
Copy link

Any updates on this? It isn't that great having to rebuild PPSSPP with Wayland WSI support if I want to use the Vulkan renderer with Wayland video driver enabled (right now I'm forced to use the OpenGL one with the Arch Linux package) 🐸

@gucio321
Copy link
Contributor Author

I'll not do anything more here. Waiting for review
CC @hrydgard

@hrydgard
Copy link
Owner

hrydgard commented Jul 25, 2023

Just tested on Mac and it doesn't break this time, nice :) Will actually review the code a bit later, gotta run. Wait I think I confused this with the DPI one.

@hrydgard hrydgard added this to the v1.16.0 milestone Jul 25, 2023
@hrydgard hrydgard added the SDL2 Issue on SDL (or Qt in SDL code) but not all ports. label Jul 25, 2023
@hrydgard hrydgard merged commit f229573 into hrydgard:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDL2 Issue on SDL (or Qt in SDL code) but not all ports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linux/SDL: fails to run on Wayland (Vulkan backend)
4 participants