-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeList: fix SDL+Wayland+Vulkan #16251
Conversation
I think this is better, but there was #11536 for some reason. Maybe a case of https://xkcd.com/1172/. -[Unknown] |
ok, so how should I handle this? |
well, what is the default state of |
ok, nevermind, I see that cmake doesn't do this way ;-) |
Hm. Not sure what to do here :) I feel that ideally we should always build with both X11 and wayland and chose at runtime... |
2e29465
to
efda3f0
Compare
Again I'm really not sure why #11536 was desired, but I also don't really see why this PR could be bad. So I'm inclined to merge it... |
Any updates on this? It isn't that great having to rebuild PPSSPP with Wayland WSI support if I want to use the Vulkan renderer with Wayland video driver enabled (right now I'm forced to use the OpenGL one with the Arch Linux package) 🐸 |
I'll not do anything more here. Waiting for review |
|
fix #16163
NOTE Please verify carefully this change since I'm not familiar with CMake at all and I could destroy something 😄