Fix the new logic-op-in-shader on OpenGL ES and D3D11 #15962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also disable BlueToAlpha for now for Outrun and DiRT 2, it breaks the water effect somehow. Will come back to it later.
unknownbrackets
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #15960
Further fixes these for D3D11 and OpenGL ES: #13012, `#11928
These APIs don't have logic op support, and we weren't using it anyway for this, we just broke if it wasn't there - need to have checks so we don't activate the old fallbacks in this case. Also better propagation of the "applyFramebufferRead" (run-in-shader) flag, that probably should be better named.
Also disable BlueToAlpha for now for Outrun and DiRT 2, it breaks the water effect somehow. Will come back to it later.