Color format cleanups #15749
Merged
Color format cleanups #15749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
the
Code Cleanup
|
|
hrydgard
force-pushed
the
color-format-cleanup
branch
from
29e69fc
to
4165e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm on a deep yak shaving quest here. The origin was the 3D texture thing (#15727 ), then when trying to expand that to more backends than Vulkan, I found I needed to refactor texture loading (#15743), which spawned a number of cleanup tasks when I ran into things that were silly and/or outdated.
This one removes the ReplaceTextureFormat enum (which had 7 unused members) and their related code, keeping only the case we are currently actively using. Then I found out that some parameters were always false these days now that we switch R/B in the shaders for the D3D backends, so cleaned up more stuff. Good to get in separately.