softgpu: Fix viewport flag clean/dirty #15529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Split/Second effects, see hrydgard#15501.
Fixes crashes in GE debugger when viewing stencil.
|
Good catches, no need to be sorry :) |
|
It's now fixed in software mode: But how about this? |
|
There's definitely a bug in softgpu lighting somewhere, I've seen this "inverted lighting" in the frame dump from #12507 as well (it's been there since before any state tracking too.) It's not related to this issue directly. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Split/Second effects, see #15501. Such dumb mistakes... sorry.
-[Unknown]