Audio: Correct protection against time skew #15009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I also notice that the background music of megaman powered up is too fast. |
|
Unless it's actually crashing, which it seems it's not, 1.12.3 will not happen for another week (next Monday) We can start merging other stuff soon anyway, I can do a release then branched from this commit. |
|
Also I should have reviewed better, my mistake too :) |
|
Not game breaker but not comportable with this :) Screenrecorder-2021-10-11-13-03-18-640.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a stupid mistake in #14998 - sorry. Not sure if it's worth a v1.12.3 or not, but the bg audio plays at a wrong speed because of this.
Refactored a ternary and flipped a condition wrong, didn't bother to retest... stupid mistake.
Also fix a related warning.
-[Unknown]