-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove I/O on thread setting #14999
Remove I/O on thread setting #14999
Conversation
Hmm.. i don't remembered some adhoc issue need to have I/O on thread to be disabled, the last time i remembered AdhocMatching callback could be affected by I/O Timing Methods, usually changing the i/o timing method could solve this. Btw, is there a reason why the default I/O Timings Method is not "Simulate UMD Delays"? Edit: nevermind, based on this #7647 it seems to have issue on a few titles, not sure whether it's still happening by now or not. |
Ideally, simulate UMD delays should be fixed to more correctly estimate UMD delays, and possibly should take into account UMD cache (which is faster than "Fast".) Then it should be enabled for UMD games only (i.e. not NP.) Right now the setting is pretty inaccurate, and I'll be honest - I kinda have no idea how to correctly model it, which is why I haven't made any improvements to it. All it does right now is try to introduce a seek delay if two reads are far apart on the ISO. It's unrelated to I/O on thread. -[Unknown] |
Should we change the ini name of the setting, so it gets reset to default for everybody? Otherwise, people might be stuck on the "wrong" value and unable to change it without modifying the ini. |
Well, I was thinking of just removing it in a follow up change. I could rename it, but this is also a reported setting and I'm doing things to look at the results per that setting so I'd rather not have the name change. But if we're going to not remove it, I'll probably want to change the name indeed. -[Unknown] |
Alright, then we'll just go ahead and remove it either in this PR or soon after. The intermediate state doesn't sound very useful, except maybe for reporting for a bit then as you say. |
Still configurable in the ini if really needed, for now.
This will also cause a purple crash screen if it's off.
5176c45
to
25da99a
Compare
Tried using the web editor to resolve the tr_TR.ini conflict - not sure how I'm allowed to push to your branch, but hey. |
When you open a pull on another person's repo, there's a checkbox to allow editing of that branch by other collaborators. -[Unknown] |
We removed this a year ago, but it was put back because of something related to adhoc - see #13096. I think that's no longer necessary, and this setting being off can actually cause crashes. It's marked experimental, which might lead to some people disabling it.
This will remove the setting entirely.
-[Unknown]