Correct guardband and Z cull behavior in software renderer #14820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Culling is based on whether clipping happens, not whether clamping happens. This is important for issues like hrydgard#12348.
This is important for several issues, like hrydgard#12058 or hrydgard#12060, where something is drawn entirely outside valid Z, and should be culled.
|
Nice!!! |
hrydgard
added
Software Rasterizer
GE emulation
|
Nice Unknown hope you will also do this to hardware renderer to fix the issue about guardband and dept/z 🎉🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to make the software renderer properly handle all the guardband cases I'm aware of, as well as all the depth clamp cases.
See #12058 for more detailed notes about this behavior.
-[Unknown]