Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(.gitlab-ci.yml) Add windows-x64 target #13998

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

jdgleaver
Copy link
Contributor

This PR adds a 64bit Windows target to the libretro .gitlab-ci.yml file.

In addition:

  • Unused includes and stages have been removed from .gitlab-ci.yml
  • The temporary output redirection file generated by the static makefile in the libretro directory has been renamed from nul to null, since nul is a forbidden filename on Windows (and it's existence on the filesystem breaks the libretro build process)

@hrydgard hrydgard added the Libretro Issue on Libretro but not all ports. label Jan 29, 2021
@hrydgard hrydgard merged commit 1e0dc11 into hrydgard:master Jan 29, 2021
@jdgleaver jdgleaver deleted the gitlab-windows branch January 29, 2021 10:59
@unknownbrackets
Copy link
Collaborator

Normally one would pipe to NUL on Windows to avoid generating output, similar to piping to /dev/null on Unixlikes. If this is run under WSL or cygwin or something you'd just use /dev/null though, right?

I guess we can remove

nul
now? And add null in its place...

-[Unknown]

@jdgleaver
Copy link
Contributor Author

I guess we can remove
ppsspp/.gitignore
nul
now? And add null in its place...

I do apologise - I didn't notice the presence of nul in the .gitignore file. Should I PR this nul -> null change?

Normally one would pipe to NUL on Windows to avoid generating output, similar to piping to /dev/null on Unixlikes. If this is run under WSL or cygwin or something you'd just use /dev/null though, right?

I'm afraid I know virtually nothing about Windows (I'm 100% Linux). I was just the only one available/willing to try and sort out the build issues on our new infrastructure. Since I didn't want to meddle too much with things I have limited experience of, I thought it safest to just change the nul filename...

@hrydgard
Copy link
Owner

hrydgard commented Jan 31, 2021

well I had issues with this creating a file called "nul" before, so...

@jdgleaver
Copy link
Contributor Author

Okay, I got rid of the null file here: #14059

Sorry this took so long! Life has been chaotic recently....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Libretro Issue on Libretro but not all ports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants