Improve some i18n things #13899
Improve some i18n things #13899
Conversation
Core/HLE/sceKernelModule.cpp
Outdated
| @@ -1720,7 +1720,7 @@ void __KernelLoadReset() { | |||
| bool __KernelLoadExec(const char *filename, u32 paramPtr, std::string *error_string) { | |||
| SceKernelLoadExecParam param; | |||
|
|
|||
| PSP_SetLoading("Loading exec..."); | |||
| PSP_SetLoading("Loading executable..."); | |||
There was a problem hiding this comment.
I think we don't actually show these messages anymore. Personally I think "exec" and "executable" wouldn't make much sense to users, but it doesn't matter since it's no longer shown.
-[Unknown]
There was a problem hiding this comment.
Oh, this reminded me something... And I found it: I prepared an issue a looong time ago but never posted it, I don't know why...
Here it is:
With this pull request, new strings have been created for game launch information.
Now we have the following strings (if I haven't missed any):
Compiling shaders...
Generating code...
Loading executable...
Loading game...
Loading modules...
Loading shader cache...
Starting graphics...
Starting modules...
But this pull request replaced the display of these strings by a spinner.
We can also read a comment in this code by @unknownbrackets which says the following:
// Don't really need this, and it creates a lot of strings to translate...
// Maybe just show "Loading game..." only?
And he also commented this:
The text was intentionally removed because it causes a lot of extra strings to translate for 1.6.0.
But the strings mentioned above are still present in the code as of now.
So...
Is the spinner permanent and shown in all cases ? Therefore these strings would be useless ?
Or should we translate all these strings anyway because they will be reused ?
There was a problem hiding this comment.
The strings are still logged I think? But don't bother translating them, it's not useful. Won't show these to the user again for the beforementioned reasons.
There was a problem hiding this comment.
OK, thanks, I'll just delete them then.
- reuse some translations - move some strings to a more suitable category I will adapt the lang .ini files accordingly.
vnctdj
force-pushed
the
i18nImprovements
branch
from
5af6ae9
to
5dd71db
Compare
I will adapt the lang .ini files accordingly.