TexCache: Improve QuickTexHash a little, cleanup ARM64 defines #13353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvement is greater on 64-bit (4.3%) than 32-bit (1.6%.)
Now that the speed is closer, disable on non-ARMV7 so we can avoid wrong compilations more often.
If it's specified, but incorrect, we would compile incorrectly. We're moving away from it anyway.
Was barely used anymore, and some users are specifying it when it's not the case, so better to detect consistently.
Was not used anymore, but was defined incorrectly in some armv8 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may help #13150, because it makes ARM64 define usage more consistent.
The speedup for QuickTexHash will mostly only be present without lazy texture hashing enabled, and then will be fairly small. The hash time itself is most improved on arm64 by 4%. On iOS it should improve by ~1.6%. My handcoded NEON implementation remains 1.4% faster than the compiler, so there's no change there - but this gap is much better than it was years ago.
Times again tested on 1024 bytes of data (i.e. 16x16 32 bit texture or 32x32 CLUT8 texture.)
-[Unknown]