More GL state leak fixing #13301
Merged
More GL state leak fixing #13301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
Aug 18, 2020
|
Looking at the sequence of changes between those builds on the buildbot, #13295 is the only thing that stands out as suspicious to me (though I don't quite understand it). Also the diff between those two builds is simply: https://github.com/hrydgard/ppsspp/compare/9ebb402..bb6219e |
|
Ok I wait for this to be merge and then test the buildbot apk.. |
|
Confirmed this pr fix #13157 |
|
Thanks for testing @Gamemulatorer ! |
|
Why this pr causing the crashes of #13307 |
|
Because I added a check for something I didn't think could happen, but it did. I'm gonna fix it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might help #13157 if we're lucky, but I still don't see how #13295 could have broken it like that.