SDL: Show the actually used sample rate in system info. #12910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it'll always be the requested 44100 though anyway.
unknownbrackets
approved these changes
May 16, 2020
|
Added another piece of debug info and made it easier to display more stats, too. (Having strange issues where it tries to use a slightly higher sample rate than it should on Mac (around 44200Hz), which results in an underrun per second or so. Will log/display stuff until I see the issue...). |
|
There's already an issue reported about that, actually. See #12705. -[Unknown] |
|
Ah, right, that looks like the same thing I'm experiencing. Somehow forgot about that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it'll always be the requested 44100 though anyway, since we don't accept other sample rates. That will be changed later probably.
(I'm debugging some strange unnecessary audio underruns on my mac).