Thin3D: use 16-bit indices. Fixes #12898. #12903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknownbrackets
approved these changes
May 15, 2020
| @@ -437,7 +438,8 @@ void PresentationCommon::CopyToOutput(OutputFlags flags, int uvRotation, float u | |||
| // Make sure Direct3D 11 clears state, since we set shaders outside Draw. | |||
| draw_->BindPipeline(nullptr); | |||
|
|
|||
| int indexes[] = { 0, 1, 2, 0, 2, 3 }; | |||
| // Wouldn't it be enough to do this only when creating the index buffer? | |||
There was a problem hiding this comment.
Yeah, we should probably move it there and just do it once. I copied from softgpu and wasn't sure if I wanted to make it use a strip/fan (even then we can do once, of course.)
-[Unknown]
There was a problem hiding this comment.
Fans are a bit poorly supported in APIs so I'd stay away from those, but a strip should work, right? Either way, I'll do that separately, want to get this in ASAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.