Audio: Remove latency setting #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This setting only changes some internal values that are shown in tests not to match PSP behavior. Removed, it now matches how the PSP works. This setting wasn't really affecting any actual audio latency. See hrydgard#11844.
unknownbrackets
force-pushed
the
config-audio
branch
from
0912e9e
to
580c74c
Compare
|
Agreed, it's been a placebo if anything. |
|
This is related to options to remove #8171? |
|
Heh, well, I think that one is somehow buggy but it does actually do something... -[Unknown] |
|
@unknownbrackets Sir I have a question why audio sync (resampling) is not showing in x86jit android device? Why only in armjit android device? |
|
No need to call me sir, I'm just a lowly whatever I am. The option only shows on devices that support 44.1kHz audio output. If the device requires 48kHz or something else, the resampler is forced on and cannot be turned off. -[Unknown] |
|
@unknownbrackets thank you Sir for the explanation 😅 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting only changes some internal values that are shown in tests not to match PSP behavior. Removed, it now matches how the PSP works.
This setting wasn't really affecting any actual audio latency. Fixes #11844.
-[Unknown]