UI: Disable render dup frames where it can't work #12743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more duplicate code and not really much faster or anything.
|
Yeah, using std::function is way better than the hacky bool pointers. Nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes it possible to use a
std::functionforIsEnabled(), and uses one instead of reassigning cached booleans with simple expressions. I left HW tess since it's a bit more complex.Overall, I think it's better to have less copies of the same expression. This also gets rid of a int-to-bool hack, which kinda shows it's worth the convenience...
Fixes #12724.
-[Unknown]