Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Vulkan/adreno: Apply workaround for Harvest Moon issue #10421 #11691

Merged
merged 2 commits into from
Dec 23, 2018

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Dec 22, 2018

Props to Unknown for the workaround idea.

@hrydgard hrydgard changed the title Vulkan/adreno: Apply workaround for Harvest Moon issue #10421 WIP: Vulkan/adreno: Apply workaround for Harvest Moon issue #10421 Dec 22, 2018
@hrydgard
Copy link
Owner Author

Yeah, good point @unknownbrackets . Marked it as WIP for now, to think more about, but I believe this can get close to a perfect workaround for this particular bug.. if we do understand it (that is, if we can get it to repro consistently...)

@zminhquanz
Copy link
Contributor

And prevent a crash on Persona 3 (deadlock on Adreno driver )

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Dec 23, 2018

This Vulkan code shouldn't be related to the Persona 3 GLES bug - is there even another Vulkan bug in Persona 3 (ref: #11355)?

-[Unknown]

@zminhquanz
Copy link
Contributor

@unknownbrackets No . Just OpenGL bug on Adreno driver

@unknownbrackets
Copy link
Collaborator

Seems to work well on my device, and I can't think of any dangers now.

-[Unknown]

@unknownbrackets unknownbrackets merged commit 2dbdd73 into master Dec 23, 2018
@unknownbrackets unknownbrackets added this to the v1.8.0 milestone Dec 23, 2018
@hrydgard hrydgard deleted the workaround-harvest-moon-adreno-bug branch December 23, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants