GPU: Clear alpha more consistently from 565 #11337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the backends all did different things. Now they are more in sync, but Vulkan still behaves slightly differently. Fixes hrydgard#11326.
|
Rekicked iOS, it failed for some Travis reason... -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the backends all did different things. Now they are more in sync, but Vulkan still behaves slightly differently.
Fixes #11326.
For the purposes of Kingdom Hearts, clearing alpha is the important bit here. Really, the right thing to do is reinterpret bits to a new framebuf, copy over depth, and somehow reinterpret bits into stencil too. It's arguable what the best thing to do for other games is.
Before, behavior was very inconsistent:
#11326 (comment)
This makes it a bit more consistent, although perhaps we could get away with clearing everything everywhere and hope no game breaks.
This also removes pointless rebinds (it's always the current framebuf.)
-[Unknown]