Conception - Ore no Kodomo o Unde Kure!! hangs after video

[daniel229]

Since f08c873 in #8757
slow effect helps it.

50:09:523 user_main    W[ME]: HLE\scePsmf.cpp:1446 scePsmfPlayerReleasePsmf(08f81bc0)
50:09:523 user_main    I[ME]: HLE\scePsmf.cpp:1400 scePsmfPlayerDelete(08f81bc0)
50:09:556 user_main    W[ME]: HLE\scePsmf.cpp:1054 scePsmfPlayerBreak(08f81bc0)
50:09:556 user_main    E[ME]: HLE\scePsmf.cpp:1057 scePsmfPlayerBreak(08f81bc0): invalid psmf player
50:09:625 user_main    I[SCEGE]: Common\FramebufferCommon.cpp:414 Creating FBO for 00044000 : 480 x 272 x 1
50:09:657 AT3Thread0   E[FileSys]: FileSystems\DirectoryFileSystem.cpp:560 DirectoryFileSystem::OpenFile: FAILED, 3 - access = 1
50:09:657 AT3Thread0   E[IO]: HLE\sceIo.cpp:1301 ERROR_ERRNO_FILE_NOT_FOUND=sceIoOpen(ms0:PSP/SAVEDATA/NPJH50583DAT/bgm001.at3, 40000001, 00000000) - file not found
50:09:660 AT3Thread0   I[ME]: HLE\sceAtrac.cpp:1898 0=sceAtracSetDataAndGetID(08e78ba0, 00018000): atrac3+ stereo audio
50:09:740 idle0        I[SCEGE]: GLES\Framebuffer.cpp:1897 Decimating FBO for 00088000 (480 x 272 x 3), age 6
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 00000008
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 00000009
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 0000000a
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 0000000b
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 00000004
50:09:908 DataPool::Se W[MM]: MemmapFunctions.cpp:91 ReadFromHardware: Invalid address 00000008

[unknownbrackets]

Maybe we should more aggressively decimate unused buffers when a new one is created, or at least flush safe ones and clear the safe flag. That could work...

Try adding this:

        for (VirtualFramebuffer *vfb : vfbs_) {
            if (!g_Config.bDisableSlowFramebufEffects && vfb->safeWidth > 0 && vfb->safeHeight > 0) {
                ReadFramebufferToMemory(vfb, true, 0, 0, vfb->safeWidth, vfb->safeHeight);
                vfb->safeWidth = 0;
                vfb->safeHeight = 0;
            }
        }

Right above this line:

ppsspp/GPU/Common/FramebufferCommon.cpp

Line 414 in 63e7304

INFO_LOG(SCEGE, "Creating FBO for %08x : %i x %i x %i", vfb->fb_address, vfb->width, vfb->height, vfb->format);

Not sure if this might have negative performance impacts...

-[Unknown]

[daniel229]

It doesn't help.

[LunaMoo]

Phantasy Star Portable series seems to be glitched by this as well and again code above doesn't help, disabling slow effects does.
Potentially other games which people report new problems with like Tekken 6 or Kingdom Hearts Birth By Sleep might also belong here, but I don't have those to test.

At least for now "Me & My Katamari" might be the only game which needs f08c873 so maybe it should find it's way into compat.ini? It will make harder to see if other games with some old bugs needed it, but seems better than having new issues.

[daniel229]

Tekken 6 's hang is the same bug.Kingdom Hearts Birth By Sleep I don't konw,but the final mix looks fine in the same area.

[unknownbrackets]

Another option is to update memory after the first safe draw, when switching to another buffer or at end of frame. That will still capture a lot of one-frame-renders, which is the situation in the Katamari game. But it'd be slightly more expensive.

Still, it'd definitely be a more general solution to the category of problem than giving up and using an ini file.

-[Unknown]

[daniel229]

Bleach 6 hangs after video.

[unknownbrackets]

Does this help?

master...unknownbrackets:gpu-minor

-[Unknown]

[daniel229]

Yes,it does.

[unknownbrackets]

Hmm, I'm not seeing problems in Kingdom Hearts either way, but I only just tried going through the intro to when you have a ship to visit the first world. Maybe I did something wrong.

-[Unknown]

[unknownbrackets]

Is this fixed now?

-[Unknown]

[LunaMoo]

Well Phantasy Star Portable series fixed, thanks:3.
Don't have anything else mentioned here to check through.

[daniel229]

All are fixed now.