-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prince of Persia Revelations title screen graphic issue #6423
Comments
Does it look correct in the softgpu? -[Unknown] |
So seems like the clut is mostly right if that's correct? Or what's wrong with it? I wonder what it's doing with those block transfers. It almost seems like the alpha is wrong. Is it doing block transfers actually or memcpy's? -[Unknown] |
Just to confirm, this is also happening at 1x internal resolution right? The clut and blending look more or less right. It's using Also, more importantly, 0x04710000 is swizzled. Do you see it trying to draw to 0x04110000 or 0x00110000? Does it show any FBOs created with that as the depthbuffer? This could be a render from the depthbuffer. -[Unknown] |
That example is a shame. It'll be slower because it's doing that, and it's hard to optimize. Oh well, anyway back to this bug. FMT is 1, so 5551. If it doesn't later reuse this VRAM as a depth buffer, then this is probably where it's supposed to create it. Or maybe we're missing a framebuffer upload. (5551 >> 8) & 0xff is actually going to be (B / 8) G A. That seems odd. Comparing these two: It really looks like it should be darkening it. Maybe I should add a way to visualize the palette to the GE debugger... Anyway, I feel like somewhere between the prim you've highlighted just now, and the prim you highlighted previously, it should be clearing or redrawing this framebuffer. -[Unknown] |
Could you try exporting a GE frame dump? These help a lot. See here for instructions - it's not hard and works on Android too: You can zip that and then drag and drop it into a reply here. -[Unknown] |
GE Dump in main menu use OpenGL. |
GE Dump in main menu & in-game use Vulkan |
Duplicate of #6423 |
Wait what? This is the same issue here. |
Haha oops, I had too many tabs open. |
As noted in #11506, this is depth texturing. Note that it uses the same address as a color buffer within the same frame, so we'll have to be smart about picking the depth buffer when we should to implement this correctly. -[Unknown] |
Yeah, that's a good observation. Tricky stuff. |
Software is also problematic |
The title screen should be completely fixed now. I'm closing this one, gonna file a separate one later about the remaining fire glitches. |
The background in menu page has wrong color since 0.9.8-890 #5767, and get some new graphic glitch since 0.9.8-1275 #6362
The text was updated successfully, but these errors were encountered: