Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prince of Persia Revelations title screen graphic issue #6423

Closed
hdd60311 opened this issue Jun 25, 2014 · 22 comments
Closed

Prince of Persia Revelations title screen graphic issue #6423

hdd60311 opened this issue Jun 25, 2014 · 22 comments
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Milestone

Comments

@hdd60311
Copy link

The background in menu page has wrong color since 0.9.8-890 #5767, and get some new graphic glitch since 0.9.8-1275 #6362

1
2
3
4

@unknownbrackets
Copy link
Collaborator

Does it look correct in the softgpu?

-[Unknown]

@hdd60311
Copy link
Author

In softgpu it still has wrong color.
1

@daniel229
Copy link
Collaborator

@unknownbrackets
Copy link
Collaborator

So seems like the clut is mostly right if that's correct? Or what's wrong with it?

I wonder what it's doing with those block transfers. It almost seems like the alpha is wrong. Is it doing block transfers actually or memcpy's?

-[Unknown]

@brujo5
Copy link

brujo5 commented Jul 9, 2014

i have the same problem on iphone 5S also is more slow.test build 0.9.8-1574

img_0057

img_0058

@daniel229
Copy link
Collaborator

Gedebugger
01
02
03
04
05
06

@unknownbrackets
Copy link
Collaborator

Just to confirm, this is also happening at 1x internal resolution right?

The clut and blending look more or less right. It's using (clut >> 8) & 0xff though, which is odd. I guess it's basically looking at A and B only. So this could be a stencil issue.

Also, more importantly, 0x04710000 is swizzled. Do you see it trying to draw to 0x04110000 or 0x00110000? Does it show any FBOs created with that as the depthbuffer? This could be a render from the depthbuffer.

-[Unknown]

@daniel229
Copy link
Collaborator

Yes,it also happen at 1x
0x00110000 is this?
01

@unknownbrackets
Copy link
Collaborator

That example is a shame. It'll be slower because it's doing that, and it's hard to optimize. Oh well, anyway back to this bug.

FMT is 1, so 5551. If it doesn't later reuse this VRAM as a depth buffer, then this is probably where it's supposed to create it. Or maybe we're missing a framebuffer upload.

(5551 >> 8) & 0xff is actually going to be (B / 8) G A. That seems odd.

Comparing these two:
https://cloud.githubusercontent.com/assets/5089290/3384588/c3687188-fc5c-11e3-8974-6bc7aaaec997.jpg
http://images6.fanpop.com/image/photos/34300000/Prince-of-Persia-Revelations-screenshot-prince-of-persia-34378998-480-272.png

It really looks like it should be darkening it. Maybe I should add a way to visualize the palette to the GE debugger...

Anyway, I feel like somewhere between the prim you've highlighted just now, and the prim you highlighted previously, it should be clearing or redrawing this framebuffer.

-[Unknown]

@unknownbrackets
Copy link
Collaborator

Could you try exporting a GE frame dump? These help a lot.

See here for instructions - it's not hard and works on Android too:
https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

You can zip that and then drag and drop it into a reply here.

-[Unknown]

@Saramagrean
Copy link
Contributor

Saramagrean commented Mar 12, 2019

GE Dump in main menu use OpenGL.
Dump.zip

@Saramagrean
Copy link
Contributor

Saramagrean commented Mar 12, 2019

GE Dump in main menu & in-game use Vulkan
ULUS10063_DUMP_Vulkan.zip

@hrydgard hrydgard added this to the Future milestone Apr 26, 2020
@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Apr 26, 2020
@hrydgard
Copy link
Owner

Duplicate of #6423

@Panderner
Copy link
Contributor

Duplicate of #6423

Wait what? This is the same issue here.

@hrydgard hrydgard reopened this Apr 26, 2020
@hrydgard
Copy link
Owner

Haha oops, I had too many tabs open.

@unknownbrackets unknownbrackets added the Depth / Z Issue involves depth drawing parameters. label Apr 26, 2020
@unknownbrackets
Copy link
Collaborator

As noted in #11506, this is depth texturing. Note that it uses the same address as a color buffer within the same frame, so we'll have to be smart about picking the depth buffer when we should to implement this correctly.

-[Unknown]

@hrydgard
Copy link
Owner

Yeah, that's a good observation. Tricky stuff.

@ghost
Copy link

ghost commented May 22, 2020

I just try ppsspp v1.9.3-913 to compare hw renderer vs sw renderer.

HW Renderer

hw-pop
hw-pop1

SW Renderer

Screenshot_20200522-090424
Screenshot_20200522-090615

@Panderner
Copy link
Contributor

v1.10.3-1459-g678d881a1 results for OpenGL and Vulkan:

OpenGL:
Screenshot_2021-01-03-19-34-15-852_org ppsspp ppsspp
Screenshot_2021-01-03-19-34-41-189_org ppsspp ppsspp

Vulkan:
Screenshot_2021-01-03-19-34-29-490_org ppsspp ppsspp
Screenshot_2021-01-03-19-34-53-776_org ppsspp ppsspp

@ghost
Copy link

ghost commented May 2, 2021

On my Redmi Note 9

Vulkan

Screenshot_2021-05-02-22-58-27-096_org ppsspp ppsspp
Screenshot_2021-05-02-22-54-41-484_org ppsspp ppsspp

OpenGL

Screenshot_2021-05-02-22-57-12-841_org ppsspp ppsspp
Screenshot_2021-05-02-22-56-01-594_org ppsspp ppsspp

@ghost
Copy link

ghost commented Aug 25, 2022

Software is also problematic
Screenshot_2022-08-25-22-37-01-442_org ppsspp ppsspp
ULUS10063.ppdmp.zip

@hrydgard
Copy link
Owner

hrydgard commented Sep 26, 2022

The title screen should be completely fixed now.

I'm closing this one, gonna file a separate one later about the remaining fire glitches.

@hrydgard hrydgard modified the milestones: Future, v1.14.0 Sep 26, 2022
@hrydgard hrydgard changed the title Prince of Persia Revelations graphic issue Prince of Persia Revelations title screen graphic issue Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Depth / Z Issue involves depth drawing parameters. GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

7 participants