Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the rather redundant DoTexture flag from vshaders. #16778

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 10, 2023

Part of #16567 and compounds with the other changes.

Slightly reduces the number of unique vertex shaders but doesn't do much for the pipeline count, as the fragment shader has a tex flag (which will stay). Still worth doing for the simplification and reduction of vertex shader generation cost.

@hrydgard hrydgard added the GE emulation Backend-independent GPU issues label Jan 10, 2023
@hrydgard hrydgard added this to the v1.15.0 milestone Jan 10, 2023
@hrydgard hrydgard added the Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. label Jan 10, 2023
@hrydgard
Copy link
Owner Author

hrydgard commented Jan 10, 2023

Weirdly, this appears to break D3D11. Will need to look at that. Fixed Hm, still have issues in software transform mode.

Actually, that problem might have been created with the LMODE change..

Nope, it was shader cache clearing again! 1b4018d

@hrydgard hrydgard marked this pull request as draft January 10, 2023 15:18
@hrydgard hrydgard marked this pull request as ready for review January 11, 2023 11:15
Slightly reduces the number of unique vertex shaders but doesn't do much
for the pipeline count, as the fragment shader has a tex flag. Still
worth doing for the simplification.
@hrydgard hrydgard merged commit 350cb55 into master Jan 11, 2023
@hrydgard hrydgard deleted the remove-tex-flag branch January 11, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Cleanup Cleanup to make future work easier. Needs to be done sometimes. GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant