GPU: Keep prevPrim_ set on flush #16614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For continuing previous verts, see hrydgard#16612. We still don't handle these quite accurately (outside software rendering), but this should be better.
Wasn't enough to set prim temporarily here.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For continuing previous verts, see #16612. We still don't handle these quite accurately (outside software rendering), but this should be better.
Looked into git history and the path, I see no reason we need to clear this - we've just been doing it for a long time, since before even we knew what that other prim type did.
And since we never set
prevPrim_forGE_PRIM_KEEP_PREVIOUS, it was wrong if we previously flushed. It would still be wrong even after fixing flush on first draw, so might as well fix both places.-[Unknown]