ULES-00516 MOH Heroes Vulkan bad vshader cached

[ppmeis]

Game or games this happens in

ULES-00561 - Medal of Honor Heroes

What area of the game / PPSSPP

After title screen emulator prompt Vulkan vshader cached error.

What should happen

No vshader error.

Logs

DebugLog.zip

Platform

Windows

Mobile phone model or graphics card

NVIDIA Geforce RTX 3070

PPSSPP version affected

v1.14-37-g4942ab7d8

Last working version

v1.12.3-1469-gcc197415b

Graphics backend (3D API)

Vulkan

Checklist

• Test in the latest git build in case it's already fixed.
• Search for other reports of the same issue.
• Try resetting settings or older versions and include if the issue is related.
• Try without any cheats and without loading any save states.
• Include logs or screenshots of issue.

[ghost]

Can't reproduce this on my phone might be a windows issue only.

[hrydgard]

Thanks for reporting this one!

No, we just ignore the error on Android (debug asserts aren't on there by default) but it's still a bug, even though there might not be any big graphical consequence. Will look into it.

[hrydgard]

We hit the case where the game uses GE_PRIM_KEEP_PREVIOUS where prevPrim_ == GE_PRIM_INVALID. Think this might later somehow confuse CanUseHardwareTransform(prim) leading us to generate a different useHwTransform flag, for what should be the same inputs to the shader cache ID generators. Haven't quite understood this yet. Hm, yeah, we end up calling CanUseHardwareTransform(GE_PRIM_INVALID) which can't be good..

I think maybe we shouldn't set prevPrim_ to GE_PRIM_INVALID in Flush, btw... not doing that is enough to fix this.

[unknownbrackets]

That sounds right to me. It seems like CanUseHardwareTransform(GE_PRIM_INVALID) would only mean DoFlush() had prevPrim_ set to GE_PRIM_INVALID, unless it's a curve.... but then how does it get there? SubmitPrim() looks like it should always set prevPrim_.

-[Unknown]

[unknownbrackets]

Okay, I saw it so opened up #16614. We were never setting prevPrim_ if it was GE_PRIM_INVALID, I changed it to use points in that unlikely case (can only happen now on very first draw.)

-[Unknown]

[hrydgard]

#16614 fixes this, closing.