Copy color from overlapping framebuffers on bind, under certain conditions #15888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. Leads to much faster performance in Juiced 2. This will later be expanded to handle more things in a more elegant way, like the framebuffer overlap in God of War for the shadows and color reinterpretation in a generic way. Fixes #15728
hrydgard
force-pushed
the
copy-color-on-bind
branch
from
edc1f47
to
51686f4
Compare
|
This is pretty safe, I'm just gonna get it in. |
|
GOW Chain Of Olympus shadow is expanded. Correct shadow |
|
@Gamemulatorer Thanks for reporting, I'll get it fixed again soon. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leads to much faster performance in Juiced 2, instead of expanding the framebuffer to encompass both two overlapping framebuffers and relying on copies for self-blending. Similar to how we're handling depth copies.
This will later be expanded to handle more things in a more elegant way, like the framebuffer overlap in God of War for the shadows and color reinterpretation.
For now, keeps checking the same compatibility flag as the previous solution, but a later goal is to get rid of it. We currently do seems to get spurious copies from this in other games, one example being Wipeout where it seems to further break the already broken lens flare. However I think that one will need to be fixed properly on its own...
Fixes #15728