Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another custom analog for touch controls #14654

Closed
2 tasks done
radityaargap opened this issue Jul 28, 2021 · 7 comments
Closed
2 tasks done

Add another custom analog for touch controls #14654

radityaargap opened this issue Jul 28, 2021 · 7 comments

Comments

@radityaargap
Copy link

radityaargap commented Jul 28, 2021

I think having the option to add another custom analog would be great for touch screen users. Especially for those who don't like visual clutter and set button opacity to zero, like me 😅.

Personally I would map the custom analogs to the action buttons and L/R.

Because with the buttons being invisible, I feel that it's so much easier to do a swipe gesture than to press on a small button on a specific place on the screen.

What should happen?

Having one more custom analog for touch controls

Who would benefit from it?

Android, iOS users

Hardware, device, or operating system?

Snapdragon 450, Redmi 5, Android Pie

Specific games?

All games in general

Does anything else have a similar feature?

Adaptive buttons on ePSXe gave me this idea

Checklist

@radityaargap
Copy link
Author

radityaargap commented Jul 28, 2021

On second thought, please add TWO more custom analogs 😁
I would set them up like this:
ppsspp
I'm sure swipe gestures will feel so much more natural on a touch screen than small buttons. Especially when they are invisible.

@iota97
Copy link
Contributor

iota97 commented Jul 28, 2021

I think having 4 analog might be quite confusing for the end user, not sure if is a good option to have.

Anyway I quickly make a build to test it if you like: download apk and source code.

@radityaargap
Copy link
Author

radityaargap commented Jul 28, 2021

Wow, you are amazing, thanks a lot. I've tried the build and it's just what I wanted.

Some things that would improve this would be:

  1. Adding the option to disable diagonal input. Because when I map the analog to the action buttons I accidentally do a combo often.

  2. Marking the analog icons with numbers to avoid confusion figuring which analog is which.

But even without these 2 things, just adding one more custom analog would be good enough for most games.

So there would be the regular left analog and 2 custom analogs. No need to put 4 customs 😅.

I hope it's not too much work and I would love to see it being implemented in the stable build.

@iota97
Copy link
Contributor

iota97 commented Jul 28, 2021

Quite simple things to do and it's a rainy holiday day so why not eheh :)

I updated the APK (same download link as before) with the change from #13107 too, you may find these new setting in the control tab in the "Gesture Mapping" menu below the "Button Style" setting. They are far from great, but you may find them handy (the double tap one at least).

About them being 4 is just that while you add 2 adding 4 is just a bit more copy paste.

For the stable build much depends on what hrydgard think about this, I can open a PR if he likes.

@radityaargap
Copy link
Author

radityaargap commented Jul 28, 2021

Oh, man. This is just too good. Without diagonal inputs, the custom analogs work perfectly now. And your implementation of gesture mapping is exactly what I wanted in the first place! 😁 This is how adaptive buttons in ePSXe works.

If I might suggest, could the gestures be mapped to two buttons and make it a toggle? Like double tap for holding L+R for example. And again, an option to disable diagonal input because with touchscreen it is so hard to be precise. I'm starting to feel like I'm asking too much here 😅.

This will make playing with touch controls so much easier. I can already think of so many ways to use these gestures. So, please @hrydgard, these features need to be implemented 😁.

@ghost
Copy link

ghost commented Jul 29, 2021

You can't enjoy playing with too many buttons on screen 👎

@radityaargap
Copy link
Author

the new touch gesture is a good enough subtitute for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants