Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Vulkan] Midnight Club 3 Dub Edition #13833

Closed
MiguelCardonaG opened this issue Dec 29, 2020 · 51 comments
Closed

[Android][Vulkan] Midnight Club 3 Dub Edition #13833

MiguelCardonaG opened this issue Dec 29, 2020 · 51 comments

Comments

@MiguelCardonaG
Copy link

What happens?

Hello!

This game has the map broken.

IMG_20201229_093937

What hardware, operating system, and PPSSPP version? On desktop, GPU matters for graphical issues.

Samsung Galaxy Note 10 Plus Exynos.
ppsspp-v1.10.3-1404-g8d2fdfc73-android.apk

Dump:
ULUS10021_0001.ppdmp.zip

@Panderner
Copy link
Contributor

Midnight Club L.A Remix also affected this issue

@Panderner
Copy link
Contributor

Midnight Club games works fine for me. I'm using POCO M3 Using Vulkan
Screenshot_2020-12-29-17-03-40-407_org ppsspp ppsspp
Screenshot_2020-12-29-17-05-12-291_org ppsspp ppsspp

@Panderner
Copy link
Contributor

@MiguelCardonaG have you tried OpenGL?

@MiguelCardonaG
Copy link
Author

@MiguelCardonaG have you tried OpenGL?

Yes, with Opengl the map looks good. Only the error comes from Vulkan.

@hrydgard hrydgard added this to the v1.12.0 milestone Dec 29, 2020
@Panderner
Copy link
Contributor

It does not occur for my POCO M3 using Vulkan

@sum2012
Copy link
Collaborator

sum2012 commented Dec 29, 2020

Where is the map broken ?
I cannot see from the picture

@MiguelCardonaG
Copy link
Author

Where is the map broken ?
I cannot see from the picture

The map has to come round (see screenshot of @Panderner) and it's square to me.

@sum2012
Copy link
Collaborator

sum2012 commented Dec 29, 2020

I don't have problem in windows.
@MiguelCardonaG can you test v1.7.4 ?
https://www.ppsspp.org/files/1_7_4/ppsspp.apk
and test v1.8 ?
https://www.ppsspp.org/files/1_8_0/ppsspp.apk

@MiguelCardonaG
Copy link
Author

MiguelCardonaG commented Dec 29, 2020

Version 1.7.4 (Vulkan)

Screenshot_20201229-162100_PPSSPP

1.8. (Vulkan)

Screenshot_20201229-162308_PPSSPP

v1.7.4 & 1.8 OPENGL:

Screenshot_20201229-162358_PPSSPP

@sum2012
Copy link
Collaborator

sum2012 commented Dec 29, 2020

We have many issue for Mali gpu

@sum2012
Copy link
Collaborator

sum2012 commented Dec 30, 2020

I have download eclipse for android from
http://dl.google.com/android/adt/adt-bundle-windows-x86-20140702.zip
Hope this week can test build ppsspp's apk

@sum2012
Copy link
Collaborator

sum2012 commented Jan 1, 2021

I still fail to build ppsspp's apk

@sum2012
Copy link
Collaborator

sum2012 commented Jan 9, 2021

I reproduce in my sister with Samsung Tab A with S Pen (SM-P200) tablet
PPSSPP cannot detect CPU
https://ibb.co/Y7hZbkV
https://ibb.co/gSrGNBP

@sum2012
Copy link
Collaborator

sum2012 commented Jan 9, 2021

I forget this page
https://ibb.co/gdSnrV1

@anr2me
Copy link
Collaborator

anr2me commented Jan 16, 2021

@hrydgard is there any recommendation of which Android Studio version, Gradle version, SDK, and NDK that worked the best for PPSSPP project?

It seems @sum2012 is having difficulty trying to build android version of PPSSPP (ndk path issue or something) to investigate this vulkan issue.

@hrydgard
Copy link
Owner

You should not try to use Eclipse.

Install Android Studio 4.0 (not 4.1!) and open the project directory. It'll try to configure itself for a while, then find the Build Variants window and choose normalOptimized as Active Build Variant. Then run.

@sum2012
Copy link
Collaborator

sum2012 commented Jan 16, 2021

Build->Generate Signed APK / APK -> APK -> Choose key file->finish

Error:Internal error: (java.lang.ClassNotFoundException) com.google.wireless.android.sdk.stats.IntellijIndexingStats$Index
java.lang.ClassNotFoundException: com.google.wireless.android.sdk.stats.IntellijIndexingStats$Index
at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
at com.intellij.util.indexing.counters.IndexCounters.(IndexCounters.java:34)
at com.intellij.util.indexing.impl.MapReduceIndex.(MapReduceIndex.java:92)
at com.intellij.util.indexing.impl.MapReduceIndex.(MapReduceIndex.java:108)
at org.jetbrains.jps.backwardRefs.index.CompilerReferenceIndex$CompilerMapReduceIndex.(CompilerReferenceIndex.java:274)
at org.jetbrains.jps.backwardRefs.index.CompilerReferenceIndex.(CompilerReferenceIndex.java:110)
at org.jetbrains.jps.backwardRefs.JavaCompilerBackwardReferenceIndex.(JavaCompilerBackwardReferenceIndex.java:13)
at org.jetbrains.jps.backwardRefs.JavaBackwardReferenceIndexWriter.initialize(JavaBackwardReferenceIndexWriter.java:80)
at org.jetbrains.jps.incremental.java.JavaBuilder.buildStarted(JavaBuilder.java:152)
at org.jetbrains.jps.incremental.IncProjectBuilder.runBuild(IncProjectBuilder.java:361)
at org.jetbrains.jps.incremental.IncProjectBuilder.build(IncProjectBuilder.java:178)
at org.jetbrains.jps.cmdline.BuildRunner.runBuild(BuildRunner.java:140)
at org.jetbrains.jps.cmdline.BuildSession.runBuild(BuildSession.java:297)
at org.jetbrains.jps.cmdline.BuildSession.run(BuildSession.java:130)
at org.jetbrains.jps.cmdline.BuildMain$MyMessageHandler.lambda$channelRead0$0(BuildMain.java:232)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

@hrydgard
Copy link
Owner

You don't need to sign if you just want to build and debug. normalOptimized builds have debug keys.

If you do want to sign, there's another mechanism for it. Make a normalRelease build instead. In a gradle.properties file in, for example, your home folder, add these entries:

RELEASE_STORE_FILE=xxx
RELEASE_STORE_PASSWORD=xxx
RELEASE_KEY_ALIAS=xxx
RELEASE_KEY_PASSWORD=xxx

where you replace xxx with the appropriate values for your keystore. build.gradle will pick those values up.

@sum2012
Copy link
Collaborator

sum2012 commented Jan 17, 2021

There is no option to me that don't sign.
1

@anr2me
Copy link
Collaborator

anr2me commented Jan 17, 2021

It's easier to choose the Debug/NormalOptimized instead of Release Build for testing purpose, you don't need to dealt with keystore.
And then choose Build APK instead of Build Bundle.

@sum2012
Copy link
Collaborator

sum2012 commented Jan 17, 2021

E:\project\5\ppsspp\CMakeLists.txt : C/C++ normalDebug|x86 : CMake Error at E:/android_sdk/cmake/3.10.2.4988404/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) (Required is at
least version "3")
Call Stack (most recent call first):
E:/android_sdk/cmake/3.10.2.4988404/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
E:/android_sdk/cmake/3.10.2.4988404/share/cmake-3.10/Modules/FindPythonInterp.cmake:152 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
ext/glslang/CMakeLists.txt:172 (find_package)

@anr2me
Copy link
Collaborator

anr2me commented Jan 17, 2021

Do you have python 3.x installed ? I think it's one of the requirements.

@sum2012
Copy link
Collaborator

sum2012 commented Jan 17, 2021

Re-doing flash new source.
1

@anr2me
Copy link
Collaborator

anr2me commented Jan 17, 2021

Are you not using NDK from SDK Manager? as i remembered the folder will be named "ndk-bundle"

Also check if you had NDK_HOME in system environment variable or not.
image

Edit:
Apparently the one from NDK location drop down also contains the version number like that, but i'm using NDK r19c (installed separately) without any problem.
image
image
I can build PPSSPP apk without any issue using all 3 version of NDK i have. (r19c, ndk-bundle, recommended)

@MiguelCardonaG
Copy link
Author

So how's it going? Is it going to be fixed?

@ghost
Copy link

ghost commented May 2, 2021

Using latest git build ppsspp apk
Screenshot_2021-05-02-20-56-07-288_org ppsspp ppsspp

@ghost
Copy link

ghost commented Oct 6, 2021

Midnight Club L.A Remix
OpenGL
Screenshot_2021-10-07-07-11-06-571_org ppsspp ppsspp
Vulkan
Screenshot_2021-10-07-07-10-41-479_org ppsspp ppsspp

@ghost
Copy link

ghost commented Oct 6, 2021

Change the title to mali gpu racing games has some broken map on vulkan backend?

@ghost
Copy link

ghost commented Oct 11, 2021

Gensou Suikoden have also an issue on map using vulkan.

OPENGL
Screenshot_2021-10-11-17-30-44-771_org ppsspp ppsspp

VULKAN
Screenshot_2021-10-11-17-31-33-255_org ppsspp ppsspp

@Panderner
Copy link
Contributor

Gensou Suikoden have also an issue on map using vulkan . OPENGL Screenshot_2021-10-11-17-30-44-771_org ppsspp ppsspp VULKAN Screenshot_2021-10-11-17-31-33-255_org ppsspp ppsspp

I can't see that map issue for Gensou Suikoden on vulkan.

@ghost
Copy link

ghost commented Oct 11, 2021

Gensou Suikoden have also an issue on map using vulkan . OPENGL Screenshot_2021-10-11-17-30-44-771_org ppsspp ppsspp VULKAN Screenshot_2021-10-11-17-31-33-255_org ppsspp ppsspp

I can't see that map issue for Gensou Suikoden on vulkan.

Use your eyes and spot the difference very minor glitch on the map, also this can only reproduce on mali gpu's

@MiguelCardonaG
Copy link
Author

Any news?

@anr2me
Copy link
Collaborator

anr2me commented Mar 11, 2022

Any news?

You can try using the workaround mentioned in #15016 (ie. PixelDepthRounding)

@MiguelCardonaG
Copy link
Author

Any news?

You can try using the workaround mentioned in #15016 (ie. PixelDepthRounding)

And how do I put it? I don't get it...

@hrydgard hrydgard modified the milestones: Future-Prio, v1.13.0 Mar 11, 2022
@ghost
Copy link

ghost commented Mar 12, 2022

Any news?

You can try using the workaround mentioned in #15016 (ie. PixelDepthRounding)

And how do I put it? I don't get it...

Create compat.ini or download the compat.ini file here in github and find the line pixeldepthrounding then add the id of midnight club games.

@hrydgard
Copy link
Owner

Closing this since #15611 works around it fine. The driver version cutoff might need adjustment, please comment if it's still not working for you.

@ghost
Copy link

ghost commented Jun 20, 2022

I can still reproduce this issue using the latest build on my Redmi note 9.
Screenshot_2022-06-20-22-05-33-377_org ppsspp ppsspp

@hrydgard
Copy link
Owner

hrydgard commented Jun 20, 2022

@Gamemulatorer if you go into settings / tools / system info, what GPU driver version does it show?

@ghost
Copy link

ghost commented Jun 20, 2022

@Gamemulatorer if you go into settings / tools / system info, what GPU driver version does it show?

Screenshot_2022-06-20-22-12-21-825_org ppsspp ppsspp

@hrydgard
Copy link
Owner

Okay, looks like I need to apply this to some higher driver versions too then. Thanks!

@MiguelCardonaG
Copy link
Author

@hrydgard

Closing this since #15611 works around it fine. The driver version cutoff might need adjustment, please comment if it's still not working for you.

PPSSPP_2022-06-20-16-21-07

PPSSPP_2022-06-20-16-19-22

I just tried it and the problem persists. 🤔

@hrydgard
Copy link
Owner

@MiguelCardonaG Please also report your GPU driver version, like GameEmulatorer did.

@MiguelCardonaG
Copy link
Author

Screenshot_20220620-170751_PPSSPP

@hrydgard
Copy link
Owner

Thanks. Maybe it just isn't fixed, I'll remove the version limitation, and will also try to report it to ARM.

@hrydgard
Copy link
Owner

That latest commit should fix it.

@MiguelCardonaG
Copy link
Author

Well, it keeps giving me the same error on the map.

@hrydgard
Copy link
Owner

Even 1.12.3-1292 ?

@MiguelCardonaG
Copy link
Author

With version 1292 it works well. Thank you!

PPSSPP_2022-06-20-18-56-01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants