Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Worms bug: worm name disappear #12380

Open
AdityaMH opened this issue Oct 1, 2019 · 28 comments
Open

All Worms bug: worm name disappear #12380

AdityaMH opened this issue Oct 1, 2019 · 28 comments
Labels
GE emulation Backend-independent GPU issues

Comments

@AdityaMH
Copy link

AdityaMH commented Oct 1, 2019

During the match (no matter what match or what worms game series), the name of the worm disappeared even though it changed option "show: name and health".

Android 7.1, OpenGL, version 9.1.2

@unknownbrackets
Copy link
Collaborator

Could you try exporting a GE frame dump? These help a lot.

See here for instructions - it's not hard and works on Android too:
https://github.com/hrydgard/ppsspp/wiki/How-to-create-a-frame-dump

You can zip that and then drag and drop it into a reply here.

-[Unknown]

@Thornskade
Copy link

Hey, so I can second this issue. It's a problem in the entire Worms series on PSP and has been a problem since I first used this emulator many years ago.

Worms have name tags on top of their health so you can differentiate them for the purposes of turn order. Curiously, all of them are either sometimes missing or display weird, corrupted-looking incorrect textures throughout the entire series. One game in the series, Worms Battle Islands, has an additional problem where the landscape pre-renderer doesn't work seemingly in a similar way as the names, making the "Tactics" mode unusable as you cannot preview the maps to spawn your gadgets.

Should I do a frame dump? The names are permanently missing or rendering badly at all times, I'm not sure how the frame dump would work/help. The issue is in plain sight the entire time.

Sorry if what I say is confusing or of little help.

@hrydgard
Copy link
Owner

Do make a frame dump, but it could be one of those issues where something happened in an early frame that ruined it for later frames so it's not always possible to tell.

@hrydgard hrydgard modified the milestones: v1.11.0, v1.12.0 Nov 29, 2020
@hrydgard hrydgard added GE emulation Backend-independent GPU issues and removed No Feedback / Outdated? labels Nov 29, 2020
@Thornskade
Copy link

Worms Battle Islands Frame Dumps.zip

Did frame dumps for Battle Islands. I couldn't get the name tag textures to corrupt but it definitely happens in the other two games. Either way the names are missing and the landscape preview is also broken.

@LunaMoo
Copy link
Collaborator

LunaMoo commented Nov 29, 2020

One of those dumps just crashes for me.
Either way the bug is real, the game tries to draw names from a texture stored in ram, but it's wrong and I can't see how it creates that texture, restarting battle doesn't re-generate the texture, but the address doesn't change when quitting the battle and starting new one so the function that writes it can be found:
PPSSPP worms
I guess it should be downloading that texture from 04088000.

unknownbrackets added a commit to unknownbrackets/ppsspp that referenced this issue Jan 17, 2021
This func takes drawn text and replaces stencil with alpha based on the
color intensity to prepare text for blending.

See hrydgard#12380.
@unknownbrackets
Copy link
Collaborator

#13938 may at least fix the text. Probably the landscape render is using another direct CPU copy which would have to be found. It's also possible different Worms games will use variants of that func, since it was really inefficient...

-[Unknown]

@Panderner
Copy link
Contributor

v1.11.2-129-gbcbfee640 Still happens
Screenshot_2021-02-20-20-35-52-164_org ppsspp ppsspp

@unknownbrackets
Copy link
Collaborator

If you open the Disassembly (or web debugger), does the function named "worms_copy_normalize_alpha" exist? You can just paste that name in the Go to field.

If it doesn't exist, it means that the non-demo version uses a slightly different function.

-[Unknown]

@Panderner
Copy link
Contributor

I can't find worms_copy_normalize_alpha in Web debugger since I don't have a PC.

@hrydgard hrydgard modified the milestones: v1.12.0, v1.13.0 Aug 21, 2021
@ghost
Copy link

ghost commented Oct 21, 2021

This game is broken on vulkan backend graphics while on opengl backend looks good.

Vulkan
Screenshot_2021-10-21-17-33-51-089_org ppsspp ppsspp

Opengl
Screenshot_2021-10-21-17-35-55-862_org ppsspp ppsspp

Software
Screenshot_2021-10-21-17-33-31-045_org ppsspp ppsspp

ge dump
worms_vulkan.zip

@ghost
Copy link

ghost commented Oct 21, 2021

Hey, I found a solution for the graphics issue on vulkan mali gpu the compat.ini DisableAccurateDepth what do you think @hrydgard?

@ghost
Copy link

ghost commented Sep 20, 2022

Looks good using the latest build.
Screenshot_2022-09-20-18-10-38-27
Might be fixed by #16043

@hrydgard
Copy link
Owner

Cool. Let's close this then.

@hrydgard hrydgard removed this from the Future-Prio milestone Sep 20, 2022
@Panderner
Copy link
Contributor

How about worm name issue?
NPEH00019_00000

@hrydgard
Copy link
Owner

Oh, OK, I thought both problems were fixed. reopening

@hrydgard hrydgard reopened this Sep 20, 2022
@light-and-ray
Copy link

I have the problem with background on the last google play version of ppsspp

@light-and-ray
Copy link

"Worms open warfare 1" is OK, but "open warfare 2" has this problem

@hrydgard
Copy link
Owner

Oh, ok. What device are you using?

@light-and-ray
Copy link

Oh, ok. What device are you using?

Android 11, retroid pocket 3+

@ghost
Copy link

ghost commented Feb 19, 2023

Oh, ok. What device are you using?

Android 11, retroid pocket 3+

That's a Mali gpu?
If yes try geometry culling

@light-and-ray
Copy link

Oh, ok. What device are you using?

Android 11, retroid pocket 3+

That's a Mali gpu?
If yes try geometry culling

Yes, Mali

I got problem with semi transparent background on the winter map in the first game (after map changing). Geometry culling didn't help

In the second game geometry culling didn't help too

IMG_20230219_121202.jpg

IMG_20230219_121216.jpg

IMG_20230219_121300.jpg

IMG_20230219_121307.jpg

@ghost
Copy link

ghost commented Feb 19, 2023

@light-and-ray how about if you try the recently build https://buildbot.orphis.net/ppsspp/
There's a chance this might be fix by #16645 nvm this is already included in 1.14.4 😅

@light-and-ray
Copy link

@light-and-ray how about if you try the recently build https://buildbot.orphis.net/ppsspp/
There's a chance this might be fix by #16645

OK i will, but tomorrow

@light-and-ray
Copy link

light-and-ray commented Feb 20, 2023

@light-and-ray how about if you try the recently build https://buildbot.orphis.net/ppsspp/ There's a chance this might be fix by #16645 nvm this is already included in 1.14.4 sweat_smile

Yes, it works. This commit megred "on Dec 23, 2022", and Google Play says last update was 3rd Jan. So I misunderstood, I thought the problem has not been fixed correctly

@light-and-ray
Copy link

P.s. on the last build it does not matter "Geometry shader culling" is checked or not

@ghost
Copy link

ghost commented Feb 20, 2023

P.s. on the last build it does not matter "Geometry shader culling" is checked or not

Try this #12380 (comment)

@light-and-ray
Copy link

@Gamemulatorer No, I meant the problem (of backgrounds) is gone. It is only needed to wait update of google play version

@light-and-ray
Copy link

Worms Battle Islands: there should be a map preview (1:30: https://www.youtube.com/watch?v=-JUf1WUezoM)
Screenshot_20230221-171747

both OpenGL and Vulkan, yesterday build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

No branches or pull requests

7 participants